An attempt at #29 #1335
Merged
An attempt at #29 #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a naming suggestion instead of |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1335 +/- ##
===========================================
+ Coverage 6.69% 78.01% +71.31%
===========================================
Files 47 48 +1
Lines 4618 4766 +148
===========================================
+ Hits 309 3718 +3409
+ Misses 4309 1048 -3261 ☔ View full report in Codecov by Sentry. |
|
|
|
No docs and no tests? |
This isn't gonna be used by the public yet so it wasnt a high priority to add docs. Will add tests when i can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
to tackle #29 :
(The multiplicity is a bug stemming from symbolic_solve, not this function).
The goal of this function is to multiply by any denominator it finds first in order to get a polynomial like shape. It then uses
polynomial_coeffsin order to get the coefficients of the "ignored" variable -s- Afterwards, it constructs a system of polys by doingspecific_coeff = 0. Then solves them using symbolic_solve.I also wrote a small attempt at using
ia_solverecursively, but ia_solve is somewhat limited in this regard and i also dont have much time (midterms :^) )